You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If this issue is time-sensitive, I have submitted a corresponding issue with GCP support.
Bug Description
The spec.memebrshipLocation field defaults to global if not set. The field would be required if the corresponding memebreship is regional. This is because the spec.memebrshipLocation field needs to match exactly the same as the corresponding Membership resource's spec.location field. However, the featuremembership resource already has the membershipRef, it should be able to infer the memebership location value from the referenced resource.
The redundant field confuses users and would cause problems if two location values are set differently in two places.
I would consider this as a design flaw in the current controller backed by DCL.
In the future direct controller, we should get the membershipLocation value from the referenced resource instead of depending on the field.
Additional Diagnostic Information
n/a
Kubernetes Cluster Version
n/a
Config Connector Version
n/a
Config Connector Mode
namespaced mode (default)
Log Output
No response
Steps to reproduce the issue
Create a GKEHubMembership resource in us-central1
Create a Gkehubfeaturemembership resource with spec.membershipLocation as empty
The Gkehubfeaturemembership KCC resource will fail to create the GCP resource
YAML snippets
No response
The text was updated successfully, but these errors were encountered:
ziyue-101
changed the title
GKEhubFeatureMembership's spec.membershipLocation field should be optional discouraged to use
GKEhubFeatureMembership's spec.membershipLocation field should be optional and discouraged to use
Aug 21, 2024
Checklist
Bug Description
The
spec.memebrshipLocation
field defaults toglobal
if not set. The field would be required if the corresponding memebreship is regional. This is because thespec.memebrshipLocation
field needs to match exactly the same as the corresponding Membership resource'sspec.location
field. However, the featuremembership resource already has the membershipRef, it should be able to infer the memebership location value from the referenced resource.The redundant field confuses users and would cause problems if two location values are set differently in two places.
I would consider this as a design flaw in the current controller backed by DCL.
In the future direct controller, we should get the membershipLocation value from the referenced resource instead of depending on the field.
Additional Diagnostic Information
n/a
Kubernetes Cluster Version
n/a
Config Connector Version
n/a
Config Connector Mode
namespaced mode (default)
Log Output
No response
Steps to reproduce the issue
YAML snippets
No response
The text was updated successfully, but these errors were encountered: