Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy controller(HNC) can't be disabled in KCC #2533

Open
3 tasks done
ziyue-101 opened this issue Aug 19, 2024 · 0 comments
Open
3 tasks done

Hierarchy controller(HNC) can't be disabled in KCC #2533

ziyue-101 opened this issue Aug 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ziyue-101
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

HNC is disabled by setting the hnc.enabled GCP API field to false. However, by setting the KCC's spec.hnc.enabled field to false doesn't set the underlying GCP API to false. This means users can't disable HNC through KCC properly. We should consider to have the behavior of setting false to a boolean in the KRM equivalent to setting false on the underlying GCP API.

Additional information

Even though users can attempt to disable HNC through Gcloud, KCC reconciliation will revert the change back.

Importance

No response

@ziyue-101 ziyue-101 added the enhancement New feature or request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant