Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link generation issue on NVidia.com #132

Open
tomayac opened this issue Mar 30, 2022 · 3 comments
Open

Link generation issue on NVidia.com #132

tomayac opened this issue Mar 30, 2022 · 3 comments
Assignees

Comments

@tomayac
Copy link
Member

tomayac commented Mar 30, 2022

(Migrated from GoogleChromeLabs/link-to-text-fragment#58, via @guihkx.)

When trying to highlight the following text:

March 29th, 2022 - Windows 473.33, Linux 470.62.26

From this page: https://developer.nvidia.com/vulkan-driver

Your extension generates the following URL:

https://developer.nvidia.com/vulkan-driver#:~:text=march%2029th%2C%202022%20-%20windows%20473.33%2C%20linux%20470.62.26

When you open the URL above on Firefox 98.0.2, it highlights the text successfully, but the same does not happen on Chrome 100.0.4896.60.

Using Chrome's built-in "Copy link to highlight" feature, this URL is generated instead (and it works on both Firefox and Chrome):

https://developer.nvidia.com/vulkan-driver#:~:text=March%2029th%2C%202022%20%2D%20Windows%20473.33%2C%20Linux%20470.62.26

Maybe it could help you find a solution.

Thank you for this extension by the way!

@woto
Copy link

woto commented Apr 28, 2022

Comparing with original link gotten from original implementation in Chrome I see two differences:

  1. The words are unreasonable downcased. It must be 'March', not 'march'
  2. hyphen character is not encoded. It must be '%2D', not '-'

Link gotten from original Chrome implementation of 'Copy link to highlight':

https://developer.nvidia.com/vulkan-driver#:~:text=March%2029th%2C%202022%20%2D%20Windows%20473.33%2C%20Linux%20470.62.26

Link gotten from Chrome extension "Copy link to selected text" (bugreported link):

https://developer.nvidia.com/vulkan-driver#:~:text=march%2029th%2C%202022%20-%20windows%20473.33%2C%20linux%20470.62.26

@tomayac
Copy link
Member Author

tomayac commented Apr 28, 2022

@tfmar, would anyone from your team be able to debug what the issue is here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants