-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally URL-encode parentheses #115
Comments
(CC: @kriegaex) |
There's a user report in GoogleChromeLabs/link-to-text-fragment#55 about spaces that need to manually be encoded to |
Well, ideally it would address all characters which need to be properly encoded. |
Report of another character that's not encoded and can invalidate the generated link: the dash |
Another case of this came up in GoogleChromeLabs/link-to-text-fragment#59. |
More issues related to URL-encoding in GoogleChromeLabs/link-to-text-fragment#87. |
(Migrated from GoogleChromeLabs/link-to-text-fragment#51.)
The Chrome extension created this link for me:
https://wiki.eclipse.org/Tycho/Reference_Card#:~:text=include%20source%20bundles)-,target%20runtime%20environment,-Specify%20which%20environments
Do you see the closing parenthesis ")" in the URL? That is a problem, just like an opening parenthesis, if you want to use that URL in a markdown documentlink, because the format is
[My description](https://my.url.org/foo/bar)
. Now when using the URL in a link directly here on GitHub, it looks like this:My description-,target%20runtime%20environment,-Specify%20which%20environments)
If I manually URL-encode the closing parenthesis as
%29
, the link looks OK:My description
So please, enable the user to specify a list of characters which should be URL-encoded by default.
The text was updated successfully, but these errors were encountered: