Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkUtils.matchUrlPattern cannot parse certain URLs #2660

Closed
OrKoN opened this issue Oct 7, 2024 · 1 comment · Fixed by #2832
Closed

NetworkUtils.matchUrlPattern cannot parse certain URLs #2660

OrKoN opened this issue Oct 7, 2024 · 1 comment · Fixed by #2832

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Oct 7, 2024

for example, https://web-platform.test:8443/webdriver/tests/support/inline.py?doc=%3C%21doctype+html%3E%0A%3Cmeta+charset%3DUTF-8%3E%0A%3Cdiv+id%3D%27from-initial%27%3Einitial%3C%2Fdiv%3E&mime=text%2Fhtml&charset=UTF-8

it seems there could be an issue with the pattern polyfill or we might be holding it wrong. Perhaps, we should implement the matching ourselves to avoid these issues?

cc @Lightning00Blade

@OrKoN OrKoN changed the title NetworkUtils.matchUrlPattern cannot parse certain URLs. NetworkUtils.matchUrlPattern cannot parse certain URLs Oct 7, 2024
@OrKoN
Copy link
Collaborator Author

OrKoN commented Oct 7, 2024

Unit tests #2661

OrKoN added a commit that referenced this issue Nov 28, 2024
It looks like the URL pattern spec has changed and more characters are
considered to be special tokens. WebDriver BiDi standard does not seem
to be, therefore, compatible with it at the moment. This change drops
urlpattern-polyfill and replaces it with custom implementation according
to the spec.

Closes #2660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant