You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Og has two forms (OgAddMultipleRolesForm & OgRemoveMultipleRolesForm) to add/remove group roles for a group memeber.
Both these form extend the OgChangeMultipleRolesFormBase class which stores the group & member data in tempstore.private.
This makes it a little complicated to alter these forms and do any kind of logic that needs to be aware of current group and the member for which the roles are being updated.
Proposed resolution
There are two options:
Pass the group & member data in $form_state
Update the current paths for role add & remove from /group/roles/add & /group/roles/remove to /group/{group}/roles/add/{member} & /group/{group}/roles/remove/{member} respectively. This will allow developers to get the group & member data from path.
I'd actually recommend that we do both.
The text was updated successfully, but these errors were encountered:
Problem/Motivation
Og has two forms (
OgAddMultipleRolesForm
&OgRemoveMultipleRolesForm
) to add/remove group roles for a group memeber.Both these form extend the
OgChangeMultipleRolesFormBase
class which stores the group & member data intempstore.private
.This makes it a little complicated to alter these forms and do any kind of logic that needs to be aware of current group and the member for which the roles are being updated.
Proposed resolution
There are two options:
$form_state
/group/roles/add
&/group/roles/remove
to/group/{group}/roles/add/{member}
&/group/{group}/roles/remove/{member}
respectively. This will allow developers to get the group & member data from path.I'd actually recommend that we do both.
The text was updated successfully, but these errors were encountered: