Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete version of OS on the server #98

Open
aminlatifi opened this issue Apr 28, 2024 · 20 comments
Open

Obsolete version of OS on the server #98

aminlatifi opened this issue Apr 28, 2024 · 20 comments
Assignees
Labels

Comments

@aminlatifi
Copy link
Member

The server we run the farming notify reward bot on runs with an obsolete OS version. It may have security vulnerabilities itself and also doesn't allow us to run updated versions of node.js. As we have to run our scripts with node v14 which is too old.

The server OS must be upgraded for its own security and won't be a blocker in the future for further development.

@aminlatifi
Copy link
Member Author

@jainkrati

@aminlatifi aminlatifi added the p1 label Apr 28, 2024
@aminlatifi aminlatifi changed the title Obsolete version of os on server Obsolete version of os on the server Apr 30, 2024
@aminlatifi aminlatifi changed the title Obsolete version of os on the server Obsolete version of OS on the server Apr 30, 2024
@mhmdksh
Copy link

mhmdksh commented Apr 30, 2024

@aminlatifi Can you dockerize this setup? So that we can easily migrate it?

CC: @geleeroyale once this is dockerized, we can easily set it up later

@aminlatifi
Copy link
Member Author

It hosts two services, givpower-bot (production) and givfarm notify reward.

@geleeroyale
Copy link

thanks - we already moved the givpower-bot - we will migrate givfarm-notify after we hopefully fixed the current errors in prod

@aminlatifi
Copy link
Member Author

I think it's better to finally to gelato service for these kind of things. Then we won't need to keep a server for these kind of stuff.

@aminlatifi
Copy link
Member Author

The server we run the farming notify reward bot on runs with an obsolete OS version. It may have security vulnerabilities itself and also doesn't allow us to run updated versions of node.js. As we have to run our scripts with node v14 which is too old.

The server OS must be upgraded for its own security and won't be a blocker in the future for further development.

@geleeroyale @mhmdksh what's the final status of this? still notify reward is there?

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jul 22, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Jul 22, 2024
@geleeroyale
Copy link

@aminlatifi I can not find a deployment or exact repo for givfarm-notify.

givpower-bot is already migrated as stated above

Can we take a look at this?

@aminlatifi
Copy link
Member Author

@geleeroyale the repo is giv-token-contracts

@geleeroyale
Copy link

@aminlatifi I am sorry, but all I see in this repo are contracts and contract deployments for hardhat - I can't find any services

@aminlatifi
Copy link
Member Author

@aminlatifi I am sorry, but all I see in this repo are contracts and contract deployments for hardhat - I can't find any services

There are scripts run every hour by cron job.

@geleeroyale
Copy link

geleeroyale commented Aug 1, 2024

@aminlatifi

I cloned the repo onto our services.giveth.io instance and tried for most of the day to get it to run - but whatever I do it won't work.

  1. not every file change has been tracked with git
    • all of the dependencies are outdated to a point that it all breaks
    • does not seem to run successfully on node14 but is set to node14 (I know its the point of this post but I am wondering why it still seems to work on the old system)

after

  • manually creating some script files in /deployments,
  • updating package dependencies,
  • switching to yarn,
  • and many in-between experiments

I was able to run one of the cronjob scripts, but it fails with an error:

Image

It would be awesome if you could clean up the repository to a point of reproducability @aminlatifi - I can't run it in the current state.

@aminlatifi
Copy link
Member Author

@geleeroyale Thanks for your effort so far. If you have prepared a safe server, I can work on make it run on that and solve issues.
Wdyt?

@geleeroyale
Copy link

Do you have any update on this @aminlatifi - do you need support?

@geleeroyale
Copy link

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

@aminlatifi
Copy link
Member Author

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

@geleeroyale Do we have a source document to tell us what is deployed where? If we have it, it would be super helpful since by looking at that we can better decide what must be deployed where.

@mohammadranjbarz
Copy link
Collaborator

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

@geleeroyale Can you give me access to new server then I can deploy notify reward bot there

FYI @aminlatifi

@geleeroyale
Copy link

Access to server has been granted, please give an update on this @mohammadranjbarz

@geleeroyale
Copy link

@mohammadranjbarz Did you manage to deploy notify reward on the services instance?

@divine-comedian divine-comedian removed the p1 label Dec 5, 2024
@divine-comedian
Copy link
Collaborator

@laurenluz

Do you recognize what these services do? I think they are related to some GIVeconomy infra. If the services are important I think this should go on your radar and see if we can get some help to work on it.

@geleeroyale
Copy link

I just had to switch out some keys on givpower and givnotify (we know why!) and took this opportunity to put the scripts on the new instance as well as the cronjobs (I escaped them for now, but to activate we just need to delete the # and off we go).

However I am not sure how it looks properly, so it would be great if @mohammadranjbarz or @aminlatifi could have a look at services.giveth.io to see if everything is alright and get acquainted with the server. I am happy to be available for that to do it together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Dev Research
Development

No branches or pull requests

5 participants