Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add the new environment variable for the **MixRamp** option? #380

Open
GioF71 opened this issue Feb 2, 2024 · 3 comments
Open
Assignees
Labels
feature coverage Coverage for a feature from the upstream project feature request Request for a new feature waiting for mpd release Waiting for an upcoming mpd release

Comments

@GioF71
Copy link
Owner

GioF71 commented Feb 2, 2024

Can you add the new environment variable for the MixRamp option?
To analyze songs on-the-fly, the mixramp_analyzer option can be enabled in mpd.conf:

mixramp_analyzer "yes"

More info: https://mpd.readthedocs.io/en/latest/user.html#mixramp

Originally posted by @skierro in #379

@GioF71 GioF71 self-assigned this Feb 2, 2024
@GioF71 GioF71 added the feature request Request for a new feature label Feb 2, 2024
@GioF71
Copy link
Owner Author

GioF71 commented Feb 2, 2024

Hello, I might be wrong but the version tagged as 'v0.23.15' does not contain the needed changes.
The next commit instead includes those changes. But I am building against the tag v0.23.15.

Have a look at this commit page:

https://github.com/MusicPlayerDaemon/MPD/commits/master/?after=c71e586c530e1d066efde7c2ca40c363f74100c7+139

The relevant commits:

Merge tag 'v0.23.15' <--- this is the first commit AFTER the tag 'v0.23.15' and does not have any tag
https://github.com/MusicPlayerDaemon/MPD/tree/5f54a8e94edb95b4652af000da168ce238b2a96d

tag v0.23.15 <--- I am building this!
https://github.com/MusicPlayerDaemon/MPD/tree/b8bfc986181a6824b7ee9c4f2c475369ca8ac931

If you check the differences, you will see that the changes needed to support mixramp_analyzer are not included in 'v0.23.15'.
Unless I am missing something.

Can you confirm?

@GioF71
Copy link
Owner Author

GioF71 commented Feb 2, 2024

Hello, I am sorry, but the feature is not part of a release yet. From what I understand, it will not even be included in 0.23.x.
The changes you request on the docker image have been implemented and are in a separate branch, of course there is an error now if you try to enable the feature, so I believe it's pointless to merge it.
We need to wait for a release that includes the feature.

@skierro
Copy link

skierro commented Feb 2, 2024

No problem. Let's wait for the official introduction of the feature in the next mpd release.

@GioF71 GioF71 added feature coverage Coverage for a feature from the upstream project waiting for mpd release Waiting for an upcoming mpd release labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature coverage Coverage for a feature from the upstream project feature request Request for a new feature waiting for mpd release Waiting for an upcoming mpd release
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants