Make heatmap and panel APIs and actions more consistent with one-another #113
Labels
Detectors
Issue affects the detectors
Functionality
Issue adds to the functionality of the package
low priority
Should be fixed eventually, but isn't urgent
Currently the two classes have similar init args, e.g.
init_xyz
andinit_xy_span
, however they can have different conceptual meanings, e.g.init_xy_span
inPanel
is a 2-tuple of floats specifying the panel dimensions in x and y, but forDetectorHeatMap
it is 2-tuple of floats specifying the range in both x and y within which the panels are expected to be found, and the a single width is automatically computed from this.Additionally,
Panel
learnsxy
,z
andxy_span
using a Gaussian model, and the final parameters can be accessed directly from these. ButDetectorHeatMap
instead learnsmu
,sig
,norm
, andz
and the user must interpret them into detector parameters. #112 will help with this.The text was updated successfully, but these errors were encountered: