Adds Thread List UI Component #621

nuno-vieira · 2024-10-14T17:45:29Z

🔗 Issue Link

Resolves https://stream-io.atlassian.net/browse/PBE-4346

🎯 Goal

Adds Thread List UI Component and implements Threads v2.

🛠 Implementation

Overall, I followed the Channel List implementation as much as possible to keep it consistent.

Summary:

Implements Tab Bar with Channel List and Thread List in the Demo App
Fixes Channel List loading shimmering effect not working
Fixes Channel List not preselecting the Channel on iPad
Adds Channel List Item background colour when selected on iPad
Adds markThreadRead() logic to ChannelViewModel
Adds new Thread List UI Component

🧪 Testing

The following QA Scenarios should be tested:
https://www.notion.so/stream-wiki/iOS-Threads-v2-bad42bdd8cc84016ace1010e1a783fea

☑️ Checklist

I have signed the Stream CLA (required)
Changelog is updated with client-facing changes
New code is covered by unit tests
Affected documentation updated (docusaurus, tutorial, CMS (task created)

Sources/StreamChatSwiftUI/ChatChannel/Reactions/MessageActions/DefaultMessageActions.swift

Stream-SDK-Bot · 2024-10-14T17:55:33Z

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamChatSwiftUI	7.14 MB	7.97 MB	+847 KB	🟢

This reverts commit 99d2699.

This reverts commit 75539ac.

…oading states

… inside a thread view

…tomized based on state changes

martinmitrevski

Looks great, really nice to see you in the SwiftUI world!
One weird thing is that I can't open the project (see the comments), although there are no conflicts in the xcodeproj file.
Let's check this tomorrow and I will do some testing afterwards.

CHANGELOG.md

Sources/StreamChatSwiftUI/ChatChannel/Reactions/MessageActions/DefaultMessageActions.swift

Sources/StreamChatSwiftUI/ChatChannelList/ChatChannelListItem.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadList.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListItem.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListScreen.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListViewModel.swift

Sources/StreamChatSwiftUI/DefaultViewFactory.swift

StreamChatSwiftUI.xcodeproj/project.pbxproj

martinmitrevski

Almost there - I left few small comments. But, I still can't open the xcodeproj on the two latest Xcodes, therefore I can't test the feature.

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListHeaderView.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListItem.swift

Sources/StreamChatSwiftUI/ChatThreadList/ChatThreadListViewModel.swift

Sources/StreamChatSwiftUI/ChatThreadList/NoThreadsView.swift

martinmitrevski · 2024-10-15T20:56:04Z

Sources/StreamChatSwiftUI/DefaultViewFactory.swift

+
+    // MARK: Threads
+
+    public func makeThreadDestination() -> (ChatThread) -> ChatChannelView<Self> {


wonder if the additional protocol methods contribute to the SDK size? 🤔

Could be... usually Structs and Protocols increase the size

Sources/StreamChatSwiftUI/Utils/MessagePreviewFormatter.swift

StreamChatSwiftUI.xcodeproj/project.pbxproj

[CI] Snapshots

martinmitrevski

LGTM! ✅ Just check if we really need that brewfile.lock file. In any case, feel free to merge it - we anyway have to add the docs in the other repo.

Brewfile.lock.json

…reuse formatting logic

[CI] Snapshots

sonarcloud · 2024-10-16T18:25:45Z

Quality Gate passed

Issues
106 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nuno-vieira requested a review from a team as a code owner October 14, 2024 17:45

nuno-vieira commented Oct 14, 2024

View reviewed changes

Sources/StreamChatSwiftUI/ChatChannel/Reactions/MessageActions/DefaultMessageActions.swift Show resolved Hide resolved

nuno-vieira added 21 commits October 14, 2024 18:56

Add threads tab to demo app

f71c2d0

Add NoThreadsView implementation

4cd882a

Add ThreadList design implementation + Add MessagePreviewFormatter

6e9ca92

Fix Channel List not preselecting a channel for iPads

2e59963

Add background selection to Channel List items on iPad

6714a1e

Revert "Fix Channel List not preselecting a channel for iPads"

96af171

This reverts commit 99d2699.

Revert "Add background selection to Channel List items on iPad"

e10cd60

This reverts commit 75539ac.

Add ChatThreadList + ChatThreadListNavigatableItem

6e40837

Add ChatThreadListLoadingView implementation and handle empty and l…

d9c0676

…oading states

Add ChatThreadListHeaderViewModifier implementation

adc9c61

Fix Channel List shimmering effect and improve shimmering animation

d45d28c

Add the possibility to customise the background of Thread List

d745725

Add ChatThreadListErrorBannerView

6f7b535

Add ChatThreadListFooterView + Loading More Theads

79f2afe

Add mark thread read logic to ChatChannelViewModel

6364a23

Add markThreadAsUnreadAction when message is the root of a thread and…

44b9b7d

… inside a thread view

Fix double mark unread action

aa57d96

Add ChatThreadListHeaderView to display new available threads

74da45e

Add thread selection logic to iPad

e1be9e4

Add a modifier that wraps the thread list so that the list can be cus…

5ab707b

…tomized based on state changes

Update CHANGELOG.md

adacc5d

nuno-vieira force-pushed the add/threads-v2 branch from f0987cb to adacc5d Compare October 14, 2024 17:56

nuno-vieira added 2 commits October 14, 2024 19:06

Add missing comments to Thread List View Model

8275785

Add more doc comments to public views

b856aa9

nuno-vieira changed the base branch from develop to main October 14, 2024 18:54

nuno-vieira changed the base branch from main to develop October 14, 2024 18:55

Add background color when a thread is selected on iPad

5f74c95

nuno-vieira added 2 commits October 14, 2024 20:26

Update CHANGELOG.md

accd20f

Add Thread List Item test coverage

47a8578

martinmitrevski reviewed Oct 14, 2024

View reviewed changes

nuno-vieira added 10 commits October 15, 2024 15:52

Add test coverage to ChatThreadListView

b7dea0a

Add Thread List View Model test coverage

163349b

Fix snapshot tests

fec1995

Remove ChatThreadListScreen since it is not needed

bebb31e

Fix changelog typoe

1fb573b

Do not pass colors to the view factory

5fa98d2

Use message preview formatter from utils

937da68

Forgotten public inits

e954494

Remove unused properties in Thread List View

13343a0

Remove unused colors and utils from ChatThreadListViewModel

4f0eaef

nuno-vieira requested a review from martinmitrevski October 15, 2024 18:47

[CI] Snapshots

cbfbc3e

martinmitrevski reviewed Oct 15, 2024

View reviewed changes

nuno-vieira added 2 commits October 15, 2024 22:59

Merge pull request #622 from GetStream/add/threads-v2-snapshots

149d123

[CI] Snapshots

Missing public inits

f20898a

martinmitrevski approved these changes Oct 16, 2024

View reviewed changes

Brewfile.lock.json Show resolved Hide resolved

nuno-vieira and others added 7 commits October 16, 2024 16:00

Fix glitch in loading view

dc60bc8

Add missing comments to some public views

96aef0f

Fix layout shift when a thread has a new unread message

48b4e6c

Add ChatThreadListItemViewModel to make it easier for customers to …

f378189

…reuse formatting logic

Fix thread list item view test not compiling

5563c83

[CI] Snapshots

7a91804

Merge pull request #623 from GetStream/add/threads-v2-snapshots

754ce6c

[CI] Snapshots

nuno-vieira merged commit 6c5cfeb into develop Oct 17, 2024
9 of 10 checks passed

nuno-vieira deleted the add/threads-v2 branch October 17, 2024 09:32

Stream-SDK-Bot mentioned this pull request Oct 18, 2024

4.65.0 Release #626

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Thread List UI Component #621

Adds Thread List UI Component #621

nuno-vieira commented Oct 14, 2024 •

edited

Loading

Stream-SDK-Bot commented Oct 14, 2024 •

edited

Loading

martinmitrevski left a comment

martinmitrevski left a comment

martinmitrevski Oct 15, 2024

nuno-vieira Oct 15, 2024

martinmitrevski left a comment

sonarcloud bot commented Oct 16, 2024


		// MARK: Threads

		public func makeThreadDestination() -> (ChatThread) -> ChatChannelView<Self> {

Adds Thread List UI Component #621

Adds Thread List UI Component #621

Conversation

nuno-vieira commented Oct 14, 2024 • edited Loading

🔗 Issue Link

🎯 Goal

🛠 Implementation

🧪 Testing

☑️ Checklist

Stream-SDK-Bot commented Oct 14, 2024 • edited Loading

SDK Size

martinmitrevski left a comment

Choose a reason for hiding this comment

martinmitrevski left a comment

Choose a reason for hiding this comment

martinmitrevski Oct 15, 2024

Choose a reason for hiding this comment

nuno-vieira Oct 15, 2024

Choose a reason for hiding this comment

martinmitrevski left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 16, 2024

Quality Gate passed

nuno-vieira commented Oct 14, 2024 •

edited

Loading

Stream-SDK-Bot commented Oct 14, 2024 •

edited

Loading