Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for system messages not updating channel.lastMessageAt #3476

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add support for system messages not updating channel.lastMessageAt #3476

merged 3 commits into from
Oct 30, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 30, 2024 •
edited
Loading

🔗 Issue Links

Resolves https://stream-io.atlassian.net/browse/PBE-6249

🎯 Goal

Add support for system messages not updating channel.lastMessageAt

🧪 Manual Testing Notes

Only the channel types that have the skip_last_msg_update_for_system_msgs set to true have this feature enabled.

  1. Open the Demo App
  2. Login with Leia Organa
  3. Add a member or remove a member of SKipppy channel
  4. The channel list should not update the order
  5. If a regular message is sent, it should update the order

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the ✅ Feature An issue or PR related to a feature label Oct 30, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner October 30, 2024 11:54
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 0.0 ms 100.0% 🔼 🟢
Duration 2.6 s 2.56 s 1.54% 🔼 🟢
Hitch time ratio 4 ms per s 0.0 ms per s 100.0% 🔼 🟢
Frame rate 75 fps 78.49 fps 4.65% 🔼 🟢
Number of hitches 1 0.0 100.0% 🔼 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
164 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

martinmitrevski
martinmitrevski approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@nuno-vieira nuno-vieira merged commit 7c55ad3 into develop Oct 30, 2024
15 checks passed
@nuno-vieira nuno-vieira deleted the add/support-system-messages-not-updating-channel-last-message-at branch October 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
✅ Feature An issue or PR related to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @martinmitrevski