Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giphy type messages are not getting deleted #2634

Open
hareshmabbly opened this issue Mar 14, 2023 · 17 comments
Open

Giphy type messages are not getting deleted #2634

hareshmabbly opened this issue Mar 14, 2023 · 17 comments

Comments

@hareshmabbly
Copy link

Describe the bug
In message listing screen when we try to delete giphy type of message it is getting deleted but when you go back to channel list and come back again to same message list screen then you will able to see that deleted giphy again. And if we try to delete that
giphy message again then we are getting error message from stream that then message is already deleted. I thing there is some issue with deleted_at and message.type because if you are in message listing screen and then delete the giphy message then we are getting value of delete_at and also message type is getting change to deleted but when you go back to channel list and from there come back again to channel you won't have that deleted_at and message.type value = deleted and that's why its showing giphy again.

Dev environment info (please complete/provide the following information):

  • Package version stream-chat-expo : "stream-chat-expo": "^5.9.0",
  • react-native or expo version : ^46.0.0
  • Device/Emulator : Android/ Ios (Also in web in stream-react library)

To Reproduce
Steps to reproduce the behavior:

  1. Go to message list screen.
  2. Long press on giphy type of message.
  3. Click on delete option.
  4. Go back to channel list screen
  5. Come back again on message listing screen you will see that deleted giphy again.

Expected behavior
Giphy should not be shown after deleting giphy message

@khushal87
Copy link
Member

Hey @hareshmabbly, we were not able to reproduce this issue on our end. Do you have any additional customization that might be interrupting with the behaviour?

@khushal87
Copy link
Member

Simulator.Screen.Recording.-.iPhone.14.-.2023-03-22.at.10.50.28.mp4

@hareshmabbly
Copy link
Author

@khushal87 please try to add atleast 5 giphy and then delete like 3rd any 4th i am 100% if you playaround with giphys for like 10 minutes and delete and add then you will this bug also i sent video to get stream support team.

@khushal87
Copy link
Member

@khushal87 please try to add atleast 5 giphy and then delete like 3rd any 4th i am 100% if you playaround with giphys for like 10 minutes and delete and add then you will this bug also i sent video to get stream support team.

Playing with giphy for the last 10 minutes and still couldn't reproduce this issue. Tried the same as you suggested with 5 giphy but that too works.

@khushal87
Copy link
Member

Do you have offline support enabled? @hareshmabbly

@hareshmabbly
Copy link
Author

@khushal87 no we don't have

@khushal87
Copy link
Member

Can you share the video or may be the support ticket number where you have shared your concerns?

@hareshmabbly
Copy link
Author

35427 this is the support ticket number

Untitled.mp4

@khushal87
Copy link
Member

Did you have an active internet connection at that time, it might be a case that the message wasn't deleted at all because of a network issue?

@hareshmabbly
Copy link
Author

@khushal87 yes internet connection was stable and it was posted by our QA team and then i was also able to reproduce it.

@khushal87
Copy link
Member

You also face this issue with React SDK, right? Asking, since you have mentioned it in your issue desc.

@hareshmabbly
Copy link
Author

Yes you are right same issue on react and thats why i thing i this issue is there then its from backend see when i get message list in that i don't get property deleted_at and also type of message is not delete also.

@khushal87 khushal87 transferred this issue from GetStream/stream-chat-react-native Mar 22, 2023
@hareshmabbly
Copy link
Author

@khushal87 do we have any update on this ?

@vanGalilea
Copy link
Contributor

@hareshmabbly we're still looking into this, please follow this issue for future updates.

@vanGalilea
Copy link
Contributor

@hareshmabbly can you please add a logger- see precisely how in our docs.

Please send us the logs gathered while the issue is reproduced.

@hareshmabbly
Copy link
Author

logs.txt
@vanGalilea these are the logs we are getting when we try to delete the giphy. So basically i added one giphy first then deleted it and it was removed successfully now i added second giphy and deleted it again and it was deleted but now when i go to the channel again i see that giphy again.

You could try same using postman api and as far as i understand it might have something to do with message listing api. Please let me if anything else needed from my side

@khushal87
Copy link
Member

Hey @hareshmabbly, please upgrade our SDK version. That might help. We are still not able to reproduce this issue.

@khushal87 khushal87 transferred this issue from GetStream/stream-chat-js Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants