Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: thread unread count persist even after a channel has been disabled #1322

Open
kennyvallejodev opened this issue Jun 3, 2024 · 7 comments
Assignees
Labels
bug Something isn't working status:confirmed

Comments

@kennyvallejodev
Copy link

Describe the bug

A clear and concise description of what the bug is.

  • If you have a thread in a channel.
    • And this thread through a reply or a mention gives you a thread_unread_count
    • And then this channel is either disabled or deleted
    • The thread_unread_count is still there
      • And because the channel is either deleted/disabled, it doesn't let you mark it as read
        so you ended up pretty much with a perma unread that you cannot get rid of

To Reproduce

Steps to reproduce the behavior:

  1. Go to a Thread and do your thing (either with another user send a reply or something) so you get a thread unread count
  2. Go to the channel and mark it as disabled (or deleted it)
  3. unexpected behavior thread unread count is still there

Expected behavior

for the threads_unread_count definitely it should omit the channels that are disabled/deleted
same for client.queryThreads
this will fetch messages from channels that are disabled (or even parent messages that are deleted lol)

Screenshots

If applicable, add screenshots to help explain your problem.

Package version

  • stream-chat-react: ^11.14.0
  • stream-chat-js:^8.25.1

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] Version 125.0.6422.114 (Official Build) (arm64)

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@kennyvallejodev kennyvallejodev added the bug Something isn't working label Jun 3, 2024
@MartinCupela
Copy link
Contributor

Hello @kennyvallejodev could you specify how do you "disable" the channel?

@kennyvallejodev
Copy link
Author

in our backend doing a partial update

    channel.updatePartial({ set: { disabled: true } }),

@kennyvallejodev
Copy link
Author

@MartinCupela do you have an update or were able to repro it?

Dunno if i should post this issue in here or in the core stream-chat repo.

Right now this issue is kinda blocking a feature that i'm working on.

@kennyvallejodev
Copy link
Author

Any update here?

@MartinCupela
Copy link
Contributor

Hey @kennyvallejodev this feature is not yet supported by the SDK. I am passing the issue to stream-chat-js repo.

@vishalnarkhede could you please take a look at this request?

@MartinCupela MartinCupela transferred this issue from GetStream/stream-chat-react Jun 12, 2024
@kennyvallejodev
Copy link
Author

can someone.... reply? at least mark the issue as confirmed lol? has been almost a month

@myandrienko
Copy link
Contributor

Hi @kennyvallejodev,

Sorry it took longer to reply. I couldn't reproduce the problem when deleting a channel, the unread count updates correctly in that case as far as I can see.

However, I can confirm that there's a bug when marking a channel as disabled. Threads in a disabled channel still count as unread, which is unexpected behavior.

I have forwarded this information to the backend team. We'll keep this issue open and update you on progress. Thanks for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:confirmed
Projects
None yet
Development

No branches or pull requests

3 participants