Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewClient panics when http.RoundTripper is *otelhttp.Transport #269

Open
rahulsinghpatwal opened this issue Mar 1, 2024 · 1 comment
Open

Comments

@rahulsinghpatwal
Copy link

rahulsinghpatwal commented Mar 1, 2024

Expected Behavior:
I should be able to construct a Go client instance with an http.Client where http.RoundTripper is *otelhttp.Transport

Actual Behavior:
NewClient panics

getting below error on creating clent"-

panic: interface conversion: http.RoundTripper is *otelhttp.Transport, not *http.Transport
goroutine 1 [running]:
github.com/GetStream/stream-chat-go/v6.NewClient({0x13fa848, 0xc}, {0x1430def, 0x40}, {0x0, 0x0, 0x8?})
/home/Rahul/go/pkg/mod/github.com/!get!stream/stream-chat-go/[email protected]/client.go:80 +0x3ea

@rahulsinghpatwal rahulsinghpatwal changed the title NewClient panics with non-Transport RoundTripper NewClient panics when http.RoundTripper is *otelhttp.Transport Mar 1, 2024
@artback
Copy link

artback commented Jun 10, 2024

changing the http.DefaultTransport can have unexpected side effects and is non recommended praxis in Go.
Set the *http.Client and Http Roundtripper using SetClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants