-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlighting and tapping on user mentions #5408
Conversation
Hello @VIPlearner, Thank you for your valuable contribution. We truly appreciate your efforts and will carefully consider your suggestion. Before moving forward, we'll need to consult with our product team to determine if we can include this in our SDK, as we aim to maintain parity with other platforms. Best regards |
Hey @VIPlearner Before proceeding further, please follow these steps to ensure code quality / styling and stability: Fix styling issues and update the API File:Run the following commands to fix any styling issues and update the API file: ./gradlew apiDump spotlessApply Resolve
|
Hi @aleksandar-apostolov Please I've updated the branch |
…elop # Conflicts: # stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/MessagesActivity.kt # stream-chat-android-compose/api/stream-chat-android-compose.api
Hi @VIPlearner & @IsaacNewton111 Thanks |
Hi @aleksandar-apostolov yes please |
However @aleksandar-apostolov Please I have a question |
...compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/MessagesActivity.kt
Outdated
Show resolved
Hide resolved
Hey @VIPlearner Thanks for your question and for your efforts on the PR! I appreciate your interest in aligning with our goals. While there are ongoing discussions with the product team about new features, our continuous focus remains on ensuring a solid and stable foundation for the project. Any contributions towards refining the core features and improving stability are always valuable. Looking forward to seeing more of your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix the conflicts and we can merge it
Done @JcMinarro |
Head branch was pushed to by a user without write access
🎯 Goal
The goal of this PR is to add functionality that allows users to click/tap user mentions.
Issue link: #5263
🛠 Implementation details
I basically scan the string for any user mentions using the @ symbol as a reference and checking the mentionedUser list to confirm the user and register the part of the string as clickable
🎨 UI Changes
🧪 Testing
Tag a user when sending a message and send. The tagged username will be clickable However nothing will happen when clicked you could however check the logs to confirm that the tagged username is being clicked