Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for full-width videos when the browser is in portrait mode #47

Open
muraldouglas opened this issue Jul 1, 2019 · 1 comment

Comments

@muraldouglas
Copy link
Contributor

muraldouglas commented Jul 1, 2019

Users should have the ability to select whether they want to have videos full-height (as we have had so far) or full-width (as has been requested by our client). If the user selects full-width video, the width is set to the width of the browser, and the height is the height of the video. This will result in unused space above and below the video, but at least the entire video can be seen.

To achieve this, the following code will be useful:

<style>
              @media (orientation:portrait) {
                section[name="story9"] {
                 background: #000;
                 z-index: 1;
                }
                section[name="story9"] .video-container {
                  margin-left: 0;
                }
                section[name="story9"] .part {
                  min-height: auto!important;
                }
                section[name="story9"] .caption {
                  padding-top: 50vh!important;
                  padding-bottom: 0!important;
                }
                
                section[name="story9"] video {
                  height: auto!important;
                  min-height: auto!important;
                  min-width: 100vw!important;
                  max-width: 100vw!important;                
                  width: 100vw!important;
                } 
              }
            </style>
@naomiaro
Copy link
Contributor

naomiaro commented Oct 8, 2019

I propose to have separate items now for original landscape video vs original portrait video coming up. Then in all screen sizes they will stay landscape or portrait.

@naomiaro naomiaro added enhancement New feature or request design work and removed enhancement New feature or request labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants