Skip to content

Implement Standardized + Type Safe Errors #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdonisCodes opened this issue Apr 9, 2025 · 0 comments · Fixed by #32
Closed

Implement Standardized + Type Safe Errors #31

AdonisCodes opened this issue Apr 9, 2025 · 0 comments · Fixed by #32
Assignees
Labels
enhancement New feature or request v0.2.2

Comments

@AdonisCodes
Copy link

Is your enhancement request related to a problem? Please describe.

Currently throwing SeleniumError to the user doesn't really help when trying to debug. You can't capture specific error cases without doing string parsing. A better approach would be to add the error type to the error, or throw specialized errors based on the error message, The APIClient can handle that!

Describe the solution you'd like

Add an type to SeleniumError & ensure that always gets populated. We can make it be a dynamic property, which checks the error message to determine the error type.

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.2.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant