Skip to content

Refactor -> Resolve all swiftlint violations / warnings #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AdonisCodes opened this issue Apr 2, 2025 · 0 comments · Fixed by #28
Closed

Refactor -> Resolve all swiftlint violations / warnings #27

AdonisCodes opened this issue Apr 2, 2025 · 0 comments · Fixed by #28
Assignees
@AdonisCodes
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@AdonisCodes
Copy link

Description

With the current swiftlint github action & generalized config file we're running into several issues mainly access control. Fix these!

Reason

Explicitly specifying the access levels makes the library more robust, because we explicitly know what code / types are being exposed.

Changes

  • Resolve all identifier name issues (only alpha numeric characters)
  • Resolve all access control issues

Additional context

https://github.com/GetAutomaApp/opensource-actions/tree/main/swiftlint
@AdonisCodes AdonisCodes self-assigned this Apr 2, 2025
@AdonisCodes AdonisCodes added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 2, 2025
@AdonisCodes AdonisCodes linked a pull request Apr 2, 2025 that will close this issue
init #28
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdonisCodes AdonisCodes

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

init GetAutomaApp/SwiftWebDriver
1 participant
@AdonisCodes