Skip to content

Fix invalid line counts #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdonisCodes opened this issue Apr 23, 2025 · 0 comments · May be fixed by #12
Open

Fix invalid line counts #11

AdonisCodes opened this issue Apr 23, 2025 · 0 comments · May be fixed by #12

Comments

@AdonisCodes
Copy link
Contributor

➜ Expectation failed: (tokens → [Tokenizer.Token(literal: "123", type: Tokenizer.TokenType.number, lineStart: 2, lineEnd: 2, start: 0, end: 4), Tokenizer.Token(literal: "456", type: Tokenizer.TokenType.number, lineStart: 3, lineEnd: 3, start: 5, end: 8)]) == (expectedOutputs → [Tokenizer.Token(literal: "123", type: Tokenizer.TokenType.number, lineStart: 2, lineEnd: 2, start: 1, end: 4), Tokenizer.Token(literal: "456", type: Tokenizer.TokenType.number, lineStart: 4, lineEnd: 4, start: 6, end: 9)])

Second output should start on line 4 not 3 as per the actual expected output. There might be some bug in the string logic where we don't increment the line number in some very specific cases.

@AdonisCodes AdonisCodes linked a pull request May 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant