Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: update Font-Awesome Icons from fontIconPicker #485

Open
abtade opened this issue Apr 19, 2022 · 4 comments
Open

BE: update Font-Awesome Icons from fontIconPicker #485

abtade opened this issue Apr 19, 2022 · 4 comments

Comments

@abtade
Copy link

abtade commented Apr 19, 2022

Hello everyone :)

Please update the Font-Awesome icons from the jQuery Plugin fontIconPicker. The newest Fontawesome version is currently 6.1.1 . This Fontawesome version has a wider variety of icons to choose from. The more icons to choose from the better I would say :)

@nhovratov
Copy link
Collaborator

@abtade Hi, we use the FontAwesome Icons from the TYPO3 core, so we don't have to ship our own Icons. But, maybe I can work out a solution to provide your own Icons, which then can be loaded into the icon picker.

@abtade
Copy link
Author

abtade commented Apr 19, 2022

@nhovratov thank you for the quick response, that would be great! :)

@medarob
Copy link
Contributor

medarob commented May 12, 2022

I noticed a similar issue:
TYPO3 10.4.27 uses FontAwesome 4.7 in the BE

@font-face{font-family:FontAwesome;src:url(../../../../../../typo3/sysext/backend/Resources/Public/Fonts/FontAwesome/fontawesome-webfont.eot?v=4.7.0);

I also use the Plugin https://github.com/DirkPersky/typo3-rte-ckeditor-fontawesome which adds a FontAwesome button to the RTE, so that I can use FontAwesome Icons in the RTE. Here I use 5.15.4 because in the FE I also use Fontawesome 5.15.4.

Because Mask uses the default FontAwesome 4.7 version from the backend, the icons in the CE are now broken because of the included FontAwesome 5.15.4 version in the BE from the Plugin.
grafik

The problem seems to be the Unicode character:
If I use the circle-o (https://fontawesome.com/v4/icon/circle-o) Icon for one of masks content elements, the unicode character is f10c in FA 4.7. This shows correctly as long as no RTE has been loaded in the backend (and FA4.7 is used).
Once a RTE editor appears, FA 5.15.4 will load and the icon will not show correctly as shown above.

Adding an option in Mask to choose FA5 or FA6 would probably solve the issue but you would probably have to adapt the icon css classes too because they are different between the FA 4, 5 and 6?

I have no idea if adding FA5 will result in any further icon errors in the TYPO3 10 BE. So far I haven't seen any false icons.

I also noticed that TYPO3 11 and TYPO3 12 still uses Fontawesome 4.7, is that correct?

@nhovratov
Copy link
Collaborator

TYPO3 still uses Fontawesome 4.7, yes. I'm not aware of an upcoming upgrade at the moment.

@nhovratov nhovratov changed the title [Feature] BE: update Font-Awesome Icons from fontIconPicker BE: update Font-Awesome Icons from fontIconPicker Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants