Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tonel] troublesome method for Tonel ... #465

Open
dalehenrich opened this issue Jan 15, 2019 · 2 comments
Open

[Tonel] troublesome method for Tonel ... #465

dalehenrich opened this issue Jan 15, 2019 · 2 comments

Comments

@dalehenrich
Copy link
Member

see pharo-vcs/tonel#72 ... will be useful to have this method in the Rowan test suite ...

@dalehenrich
Copy link
Member Author

Found another troublesome method in the GemStone base image ((presumably the $$] ... $$ ] passes):

Extension { #name : 'CPreprocessor' }

{ #category : 'Private' }
CPreprocessor >> _initializePaths [
	| list |
  self nativeCppCmd .
	list := { '' }.
	(path ~~ nil and: [path first == $$]) ifTrue: [list add: self directory].
  cppArchMType ifNil:[  "not using native cpp"
	  list add: '/usr/include/'; add: '/usr/local/include/' .
    systemSearchPaths := { } .
  ] ifNotNil:[
    systemSearchPaths := { '/usr/include/' . '/usr/local/include/' }.
    cppArchMType == 50 ifTrue:[ systemSearchPaths add: '/usr/include/linux' ].
  ].
  searchPaths := list .

]

Results in the following stack:

./tonelParserDebug.tpz rowan_dev_350 -D -- -l -- problem_CPreprocessor.extension.st
Starting tonelParserDebug.tpz at 2019-07-23T15:57:55-07:00.
class definition #'CPreprocessor'
Last selector parsed was: '_initializePaths'
-----------------------------------------------------
 Near line 73 of file /home/dhenrich/rogue/_homes/rogue/_home/server/stones/rowan_dev_350/git/scripts/tonelParserDebug.tpz
GemStone: Error         Nonfatal
a TonelParseError occurred (error 2710), , Can't parse method body
Error Category: 231169 [GemStone] Number: 2710  Arg Count: 1 Context : 90580225 exception : 90572801
Arg 1: [20 sz:0 cls: 76289 UndefinedObject] nil
topaz > exec iferr 1 : stk 
==> 1 TonelParseError (AbstractException) >> _signalWith: @6 line 25   [methId 5133569]
2 TonelParseError (AbstractException) >> signal: @3 line 7   [methId 5134081]
3 TonelParseError class (AbstractException class) >> signal: @3 line 4   [methId 5116673]
4 TonelParser >> methodBody                     @60 line 39   [methId 47772161]
5 TonelParser >> methodDef:                     @7 line 8   [methId 47770369]
6 [] in TonelParser >> methodDefList            @17 line 11   [methId 47546881]
7 ExecBlock0 (ExecBlock) >> on:do:              @3 line 44   [methId 4861441]
8 TonelParser >> methodDefList                  @11 line 17   [methId 47768577]
9 TonelParser >> document                       @3 line 4   [methId 47769857]
10 TonelParser >> start                          @2 line 2   [methId 47767297]
11 [] in Executed Code                           @35 line 18   [methId 90561793]
12 [] in AbstractFileReference >> readStreamDo:  @9 line 4   [methId 43761409]
13 ExecBlock0 (ExecBlock) >> ensure:             @2 line 12   [methId 4868097]
14 FileReference (AbstractFileReference) >> readStreamDo: @5 line 5   [methId 42138369]
15 Executed Code                                 @26 line 14   [methId 90557441]
16 GsNMethod class >> _gsReturnToC               @1 line 1   [methId 5218561]
  [GsProcess 90580225]
Stopping at line 73 of /home/dhenrich/rogue/_homes/rogue/_home/server/stones/rowan_dev_350/git/scripts/tonelParserDebug.tpz

dalehenrich added a commit that referenced this issue Jul 23, 2019
…arser instead of the insufficient patterm matching technique currently used
dalehenrich added a commit that referenced this issue Jul 23, 2019
dalehenrich added a commit that referenced this issue Jul 23, 2019
dalehenrich added a commit that referenced this issue Jul 24, 2019
dalehenrich added a commit that referenced this issue Jul 24, 2019
dalehenrich added a commit that referenced this issue Jul 24, 2019
…and regression in testMethod: 11 run, 9 passed, 2 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
… from testMethodDef ... methodBody logic needs work ...

12 run, 11 passed, 1 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
…onelScanner classes ... just to make it easier to track differences ... and use overrides instead of explicit method name changes

12 run, 11 passed, 1 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
12 run, 11 passed, 1 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
…ould fail using the original TonelParser

12 run, 12 passed, 0 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
dalehenrich added a commit that referenced this issue Jul 24, 2019
…o-vcs/tonel#72, the Rowan TonelParser class properly reads the Tonel class file and the new Rowan TonelParser class does as well ... added testIssue465 ...

12 run, 12 passed, 0 failures, 0 errors
dalehenrich added a commit that referenced this issue Jul 24, 2019
…arser test and passes NewTonelParser test, so this is a real parser problem
dalehenrich added a commit that referenced this issue Jul 24, 2019
@dalehenrich dalehenrich mentioned this issue Jul 25, 2019
dalehenrich added a commit that referenced this issue Jul 25, 2019
owan STON Cypress Tonel FileSystemGs tests for GemStone '3.2.15'
1287 run, 1255 passed, 12 failed, 20 errors
  errors
	DiskFileSystemTest>>#testChildrenSortingRoot
	DiskFileSystemTest>>#testCopyWithCorrectBasename
	DiskFileSystemTest>>#testFileNames
	FileHandleTest>>#testTruncate
	FileReferenceTest>>#testUpToAll
	JadeServerTest>>#test_updateFromSton
	RowanBrowserServiceTest>>#test_windowsRegistry
	RowanMethodServiceTest>>#test_classNameIsString
	RowanTestClassServiceTest>>#test_dirtyState
	RowanTestClassServiceTest>>#test_setSuperSubIndicators
	RwBrowserToolApiTest>>#testMoveGlobalExtensionSessionMethods
	RwHybridBrowserToolTest>>#testHybridMoveMethodFromSessionMethodsIntoSessionMethods
	RwHybridBrowserToolTest>>#testHybridMoveMethodIntoSessionMethods
	RwProjectComponentDefinitionsTest>>#testCloneComponentProject
	RwProjectComponentDefinitionsTest>>#testLoadRowanSample1_masterV20
	RwProjectFiletreeReaderWriterTest>>#testWriterReader_Rowan_pharo
	RwProjectTonelReaderWriterTest>>#testWriterReader_Rowan_pharo
	RwRowanProjectIssuesTest>>#testIssue215_move_class_and_extension_method_to_new_symbol_dict
	RwRowanProjectIssuesTest>>#testIssue495_move_class_and_extension_method_to_new_symbol_dict
	ZnCharacterEncoderTests>>#testUTF8Back
  failures
	RowanMethodServiceTest>>#test_noStepPoints
	RowanMethodServiceTest>>#test_stepPoint1
	RowanMethodServiceTest>>#test_stepPoint2
	RowanMethodServiceTest>>#test_stepPoint3
	RwLoadingTest>>#testPoolDictionaryChanges
	RwRowanIssue493Test>>#testMoveClassBetweenSymDicts_changeDefaulSymDict_2
	RwRowanProjectIssuesTest>>#testIssue310
	RwRowanSample4Test>>#testIssue490_rename_package_move_newClassVersion_newProject_1
	RwRowanSample4Test>>#testLoadProjectNamed_493
	RwRowanSample7Test>>#testCreateComponentProject
	RwSentButNotImplementedTest>>#testSentButNotImplemented
	RwSymbolDictionaryTest>>#testClassVersioningPatch

Rowan STON Cypress Tonel FileSystemGs tests for GemStone '3.5.0'
1286 run, 1225 passed, 11 failed, 50 errors
  errors
	DiskFileSystemTest debug: #testChildrenSortingRoot
	DiskFileSystemTest debug: #testCopyWithCorrectBasename
	DiskFileSystemTest debug: #testFileNames
	FileHandleTest debug: #testTruncate
	FileReferenceTest debug: #testUpToAll
	JadeServerTest debug: #test_updateFromSton
	RowanBrowserServiceTest debug: #test_windowsRegistry
	RowanMethodServiceTest debug: #test_classNameIsString
	RowanTestClassServiceTest debug: #test_dirtyState
	RowanTestClassServiceTest debug: #test_setSuperSubIndicators
	RwBrowserToolApiTest debug: #testLoadFullMultiProjectDefs
	RwBrowserToolApiTest debug: #testLoadMultiProjectDefs
	RwBrowserToolApiTest debug: #testMoveGlobalExtensionSessionMethods
	RwBrowserToolApiTest debug: #testNewClassVersionB
	RwBrowserToolApiTest debug: #testNewClassVersion_session_method_change_extension_method_protocol
	RwBrowserToolApiTest debug: #testNewClassVersion_session_method_change_extension_method_source
	RwBrowserToolApiTest debug: #testNewClassVersion_session_method_unchanged_extension_method_protocol
	RwHybridBrowserToolTest debug: #testHybridMoveMethodFromSessionMethodsIntoSessionMethods
	RwHybridBrowserToolTest debug: #testHybridMoveMethodIntoSessionMethods
	RwProjectComponentDefinitionsTest debug: #testLoadRowanSample1_masterV20
	RwProjectFiletreeReaderWriterTest debug: #testWriterReader_Rowan_pharo
	RwProjectTonelReaderWriterTest debug: #testWriterReader_Rowan_pharo
	RwProjectToolTest debug: #testDiskSimpleProject1
	RwProjectToolTest debug: #testProjectClassExtensions
	RwProjectToolTest debug: #testProjectClassExtensionsInSeparateSymbolDictionaryTheRightWay
	RwProjectToolTest debug: #testSimpleProject1
	RwProjectToolTest debug: #testSimpleProject2
	RwProjectToolTest debug: #testSimpleProject3
	RwReconcileToolApiTest debug: #testReconcileGlobalExtensionMethods_issue_290
	RwRowanProjectIssuesTest debug: #testIssue150_branches
	RwRowanProjectIssuesTest debug: #testIssue215_move_class_and_extension_method_to_new_symbol_dict
	RwRowanProjectIssuesTest debug: #testIssue495_move_class_and_extension_method_to_new_symbol_dict
	RwRowanSample1Test debug: #testIssue345
	RwRowanSample2Test debug: #testAutomaticMigration
	RwRowanSample2Test debug: #testDeferredMigration
	RwRowanSample2Test debug: #testNoMigration
	RwRowanSample2Test debug: #testNoMigration_bitbucket
	RwRowanSample2Test debug: #testNoMigration_gitlab
	RwRowanSample2Test debug: #testNoMigration_gitolite
	RwRowanSample2Test debug: #testRemoveSubclassOfClassWithNewVersion
	RwRowanSample2Test debug: #testSampleDefaultConfiguration
	RwRowanSample4Test debug: #testLoadProjectNamed_221B
	RwRowanSample4Test debug: #testLoadProjectNamed_221C
	RwRowanSample4Test debug: #testLoadProjectNamed_221D
	RwRowanSample4Test debug: #testSampleCompoundConfiguration
	RwRowanSample4Test debug: #testSampleProjectLoadConfiguration
	RwRowanSample4Test debug: #test_projectUrl_issue_463
	RwRowanSample7Test debug: #testCreateComponentProject
	RwRowanSample7Test debug: #testCreateNewProjectFromUrl
	ZnCharacterEncoderTests debug: #testUTF8Back
  failures
	RowanMethodServiceTest debug: #test_noStepPoints
	RowanMethodServiceTest debug: #test_stepPoint1
	RowanMethodServiceTest debug: #test_stepPoint2
	RowanMethodServiceTest debug: #test_stepPoint3
	RwLoadingTest debug: #testPoolDictionaryChanges
	RwProjectConfigurationsTest debug: #testRowanLoadConfiguration
	RwRowanIssue493Test debug: #testMoveClassBetweenSymDicts_changeDefaulSymDict_2
	RwRowanProjectIssuesTest debug: #testIssue310
	RwRowanSample4Test debug: #testIssue490_rename_package_move_newClassVersion_newProject_1
	RwRowanSample4Test debug: #testLoadProjectNamed_493
	RwSentButNotImplementedTest debug: #testSentButNotImplemented
@dalehenrich
Copy link
Member Author

work has been deferred until new FileSystem code (smalltalkci_port branch at moment) has been merged into candidateV2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant