Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray runner: better support for killing #164

Open
johann-petrak opened this issue Mar 29, 2022 · 0 comments
Open

Ray runner: better support for killing #164

johann-petrak opened this issue Mar 29, 2022 · 0 comments

Comments

@johann-petrak
Copy link
Collaborator

Currently we just set a flag to abort the pipeline loop when Ctrl-C is pressed.

This will not work (well) with a pipeline which uses pipe() where a large number of documents are processed by the pipe.

One possible way: escalate the way we try to abort processing each time Ctrl-C is pressed and eventually forcibly kill all processes.

In addition, we could also trap the KILL signal on the main process and directly forward this to kill all processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant