42 check pointer not null #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add class: 'EventPlayer'.
This update includes several changes aimed at improving memory management, configuration process. Notably, it migrates the Bank class usage to leverage across various components, ensuring safer memory management and ownership semantics. An adjustment in the class is the modification of the method parameter to accept a rvalue reference. This move aligns with modern C++ practices for resource management, enabling efficient transfer of ownership of card objects into a player's hand without unnecessary copying. On the configuration front, the introduction of JSON parsing for setting up Drogon HTTP listeners and application configurations directly within the codebase provides greater flexibility. Additionally, the codebase witnesses a broad application of in drawing cards from the market, further exemplifying the adoption of modern C++ features to handle operations that may not always succeed. This use of introduces clearer semantics for handling these cases. Signed-off-by: AngTsusiong <[email protected]>
This was
linked to
issues
May 17, 2024
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @HuaYuan-Tseng work, I add some check to prevent segmentation fault.
#42