Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repository] Use Database to implement repository interface #17

Open
YingChen-Lee opened this issue Aug 15, 2023 · 1 comment
Open

[Repository] Use Database to implement repository interface #17

YingChen-Lee opened this issue Aug 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@YingChen-Lee
Copy link
Collaborator

For now, we use in memory repository. However, we will need to use database as repository.

We need to add new implementation of repository interface. Also, modify the parameter of GameRepository::SaveGame and GameRepository::AddGame to take raw pointer instead of shared_ptr.

@HuaYuan-Tseng HuaYuan-Tseng added the enhancement New feature or request label Aug 15, 2023
@angtsusiong
Copy link
Contributor

The map games_ should use shared pointers. It stores the object that is currently in use and is responsible for updates to the database.
The memory of the game object should be destroyed, if currently we don't need to manipulate the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants