Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote should not overwrite server_hostname #2425

Open
MrQubo opened this issue Jul 7, 2024 · 3 comments
Open

remote should not overwrite server_hostname #2425

MrQubo opened this issue Jul 7, 2024 · 3 comments

Comments

@MrQubo
Copy link
Contributor

MrQubo commented Jul 7, 2024

import ssl
from pwn import *

io = remote('172.22.0.2', 9090, ssl=True, ssl_args={ 'server_hostname': 'example.com' })
...

In the above code server_hostname will be overwritten with '172.22.0.2'.

@Arusekk
Copy link
Member

Arusekk commented Jul 9, 2024

You can change assignments to setdefault probably.

@MrQubo
Copy link
Contributor Author

MrQubo commented Jul 9, 2024

Should I create PR to dev or stable?

@MrQubo
Copy link
Contributor Author

MrQubo commented Jul 9, 2024

I think we should jest error if 'server_hostname' is set in ssl_args and sni is not False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants