Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Validation #73

Open
Alaalser opened this issue Apr 10, 2021 · 0 comments
Open

Fix Search Validation #73

Alaalser opened this issue Apr 10, 2021 · 0 comments

Comments

@Alaalser
Copy link
Collaborator

Since we used one input to search for firstName or lastName or phone.

In this case, the input value will be the same for the 3 things and that's will make the request failed because every field has a different validation.

image

As you can see in the picture
search?firstName=Vivian&lastName=Vivian&phone=Vivian
In search cases, we don't have to be very strict on what values the user will input, but in post request, we should care about it.
Instead of validation for search, we can handle a message that tells the user there is no result for your input value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant