Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add documentation for using vectors of trust #464

Closed
wants to merge 2 commits into from

Conversation

jmhooper
Copy link
Contributor

This commit adds documentation to describe vectors of trust.

This commit does not remove ACR value documentation. ACR values will continue to be supported for some period of time while vectors of trust are rolled out.

This commit primarily describes how the feature works in OIDC.

This commit adds documentation to describe vectors of trust.

This commit does not remove ACR value documentation. ACR values will continue to be supported for some period of time while vectors of trust are rolled out.

This commit primarily describes how the feature works in OIDC.
@@ -130,6 +130,10 @@ In an **unsuccessful authorization**, the URI will contain the parameters `error
<p>
Multiple values can be joined with a space (before being URI-escaped in the final URL).
</p>
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in another pass we can go add markdown="1" to the <div> surrounding this so we can author text changes like this in markdown

@@ -0,0 +1,62 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename here is intended to match up to the trustmark we have published in the repo: https://github.com/18F/identity-idp/blob/5837343cd6c1a9fe3f78d56d9931808e108e80a0/config/application.yml.default#L344

<div class="grid-col-7">
A URL linking to the Trustmark for the <code class="language-plaintext highlighter-rouge">vtr</code> parameter.
This should be set to <a class="usa-link" href="{{ '/vot-trust-framework/' | prepend: site.baseurl }}">
https://developer.login.gov/vot-trust-framework</a>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is intentionally not configured to use the baseurl here. It needs to match the expected VTM value that the IdP knows about: https://github.com/18F/identity-idp/blob/5837343cd6c1a9fe3f78d56d9931808e108e80a0/config/application.yml.default#L344

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our canonical domain name for these docs is the plural one (developers), should we use that here (and in the VM claim?)

Suggested change
https://developer.login.gov/vot-trust-framework</a>.
https://developers.login.gov/vot-trust-framework</a>.

##### Why it's happening
The vectors of trust found in the VTR parameter are not valid
##### What to do:
- Check the `vot` parameter in your authentication request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be vtr? In the Biometric Pilot documentation for partners, we are telling them to use the vtr parameter, such as vtr=["Pb","P1"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oidc-sinatra sample app uses the vtr parameter in the auth request.

@tahineemay
Copy link

We can go ahead and close this PR, @jmhooper - confirmed as outdated and Team Melba will follow up

@jmhooper jmhooper closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants