You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I modified the Allocate callback (VmaDeviceMemoryCallbacks) of our local copy to include additional information about the used VmaPool and dedicated allocations.
The signature is now basically
This requires some data pipelining (aka making sure the new parameters are available at the call site) but nothing all to crazy.
We have done this to improve statistic tracking and simplify interop tracking.
Ideally we would like to upstream this change (so we do not have to keep a fork).
Is this something you would be willing to accept? We can make the PR.
The text was updated successfully, but these errors were encountered:
Thank you for the proposal, but I want to avoid complicating the library code by adding new features like this. Adding new parameters to PFN_vmaAllocateDeviceMemoryFunction would break backward-compatibility, so I would need to extend the structure VmaDeviceMemoryCallbacks with some new version PFN_vmaAllocateDeviceMemoryFunction2, which would add more code.
I modified the Allocate callback (VmaDeviceMemoryCallbacks) of our local copy to include additional information about the used VmaPool and dedicated allocations.
The signature is now basically
This requires some data pipelining (aka making sure the new parameters are available at the call site) but nothing all to crazy.
We have done this to improve statistic tracking and simplify interop tracking.
Ideally we would like to upstream this change (so we do not have to keep a fork).
Is this something you would be willing to accept? We can make the PR.
The text was updated successfully, but these errors were encountered: