Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out stats for dedicated blockCount and bytes. #380

Open
alecazam opened this issue Nov 2, 2023 · 2 comments
Open

Split out stats for dedicated blockCount and bytes. #380

alecazam opened this issue Nov 2, 2023 · 2 comments
Labels
feature Adding new feature wontfix This will not be worked on

Comments

@alecazam
Copy link

alecazam commented Nov 2, 2023

Dedicated blocks get thrown into the blockCount, but I'm trying to see that increase/decrease and want that to correspond with the 64MB allocations that represent heap growth. Would be good to split these counts and memory totals out per heap/memory type.

These could be added without changing the existing stats. Then just subtract them from the existing stats to get a better sense of block allocation growth.

@adam-sawicki-a
Copy link
Contributor

I'm sorry, but I don't want to add this feature to avoid feature creep.

Why do you need this information?

In what cases are allocations created as dedicated in your code outside of your control (without using VMA_ALLOCATION_CREATE_DEDICATED_MEMORY_BIT flag)? Is it due to their size, or some other reason?

You can emulate desired behavior by having a separate custom pool with non-zero VmaPoolCreateInfo::blockSize (which does not accept dedicated allocations), another one where you would create all the allocations with VMA_ALLOCATION_CREATE_DEDICATED_MEMORY_BIT flag, and fetch their statistics.

@adam-sawicki-a adam-sawicki-a added feature Adding new feature wontfix This will not be worked on labels Nov 3, 2023
@alecazam
Copy link
Author

alecazam commented Nov 3, 2023

Doesn't seem like feature creep, since the default pools have a set of dedicated and non-dedicated allocation. The default pools just don't track or report stats on the count or size of the dedicated allocations (f.e. in the json dump or in getting detailed stats).

I can track which elements I send down for dedicated allocation and approximate sizes, but don't know their exact sizes, memory type, heap used etc. Feels like this is 2 extra numbers per stat. This is mostly our images vs. rtt. All our rtt set dedicated bit. Just that then the blockCount corresponds with our 64MB allocations instead of included 1K to 30MB dedicated RTT allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new feature wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants