Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking username in logs #2196

Open
josephmhiggins opened this issue Mar 10, 2023 · 1 comment
Open

Avoid leaking username in logs #2196

josephmhiggins opened this issue Mar 10, 2023 · 1 comment

Comments

@josephmhiggins
Copy link

GNS3 users that use the GNS3 VM get destroyed when something bad happens to the GNS3 VM - for whatever reason.
The primary culprit is that they are not "ending" their project by exporting it.
This is not explicitly taught anywhere.
There are several implementations in export_project.py that I consider sub-standard (not enough log messages are written out).
I will "end" all my projects.
It will take make about 10 days to do it because I have to "fill out the paperwork" and make sure I have things like a "topology.png", a proper accounting of my "log" files.
The "log" files will be tricky because export_project.py refuses to export them - which looks like a good design to me.
The "capture" files will be tricky because export_project.py refuses to export them - which looks like a good design to me.

GNS3 users do not like to reveal their username (and I am actively engaged in finding the RFC that says you should not reveal your username, but I can not find the RFC that says people should not reveal their username), so this message:

Error while closing project 1f9cabd3-9c0d-428b-96be-c09efc7a86a4: Project 'AlmaLinux' cannot be deleted because it is not in the default project directory: 'C:\Users\joe_I7\GNS3\projects'

  1. looks to be an illegal design. Although, I will have to wait until I can find the RFC for conclusive direction,
  2. Ummm.....'AlmaLinux' cannot be deleted because it is not in the default project directory.....
    I do not know what to make of it at this time. At this time, i have a
    projects\vmware
    projects\virtualbox

I moved yesterday on C:\Users\joe_I7 and I used Replace in my code to strip out powershell $HOME in my log messages - which only I can see.
The linux way of ~/ looks better to me.
GNS3 users do not like revealing their username.
However, GNS3 users do not like revealing their hostname.
Unfortunately, I know of no such RFC that says you can not promulgate your hostname.

So...yeah...I suggest the username be stripped from all log messages done by GNS3.
That's just what GNS3 users want.

@josephmhiggins
Copy link
Author

For Windows 10 users, "it is not in the default project directory:"
%homepath%\GNS3\projects'
might be best. I do not know...

@grossmj grossmj changed the title GNS3 End Project Avoid leaking username in logs May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant