Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema 6 update in PR #732 missing in schema 7 and 8 #849

Closed
ghost opened this issue Dec 19, 2023 · 1 comment · Fixed by #854
Closed

Schema 6 update in PR #732 missing in schema 7 and 8 #849

ghost opened this issue Dec 19, 2023 · 1 comment · Fixed by #854

Comments

@ghost
Copy link

ghost commented Dec 19, 2023 •
edited by ghost
Loading

In PR #732 the schema 6 (schemas/appliance_v6.json) got some small updates, but these changes were not added to schema 7 (schemas/appliance_v7.json). While the addition of qemu console_type "spice+agent" made it into schema 8 (schemas/appliance_v8.json), the console_type "none" was not added into 8.

Is that done intentionally? Or are the updates missing in v7 and v8?
@grossmj grossmj linked a pull request Jan 12, 2024 that will close this issue
Update console_type in appliance schemas v7 and v8 #854
Merged
grossmj added a commit to GNS3/gns3-gui that referenced this issue Jan 12, 2024
@grossmj
Add missing console_type values in appliance_v8.json. Ref GNS3/gns3-r…
2a72ad5 
…egistry#849
@grossmj
Copy link
Member

grossmj commented Jan 12, 2024

Thanks for catching that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update console_type in appliance schemas v7 and v8 GNS3/gns3-registry
1 participant
@grossmj