Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on communication errors for docker build tool #814

Closed
ghost opened this issue Sep 14, 2023 · 2 comments
Closed

Retry on communication errors for docker build tool #814

ghost opened this issue Sep 14, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 14, 2023

There were a few communication errors between the Actions VM and the GitHub container registry ghcr.io when the Docker build tool was launched. docker buildx build tries to recover them by retrying the operation, for example see the log https://github.com/GNS3/gns3-registry/actions/runs/5640774106/job/15277861234. Of course retrying works only on short outages, longer ones result in a failure, for example https://github.com/GNS3/gns3-registry/actions/runs/5463988019/job/14792430012. But every successful recovery reduces the need for manual intervention.

The build tool itself has no retry mechanism, so https://github.com/GNS3/gns3-registry/actions/runs/5819569855/job/15778227464 failed. Therefore I added a retry mechanism to the docker build tool and tested it locally and on GitHub Actions. While locally it works as expected, my tests with Actions VMs showed no result as no communication error occurred.

So I'm not sure, if this retry mechanism should be added to the docker build tool. On the pro side it should reduce the number of manual actions needed. On the con side, it is currently not needed and will only increase the complexity of the tool.

Anyway here is the patch file, it can be added by git am: 0001-Docker-build-Retry-on-communication-errors.patch.txt
Alternatively I can create a PR.

@grossmj
Copy link
Member

grossmj commented Sep 15, 2023

Looks good, yes please create a PR. Thanks 🙏

@ghost
Copy link
Author

ghost commented Sep 15, 2023

Closed by PR #817

@ghost ghost closed this as completed Sep 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant