Bugfix/#286 closed channel exception #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverts some resource-leak refactorings 5e8ba71 which closes the resources to eagerly
rtroilo
force-pushed
the
bugfix/#286-closed_channel_exception
branch
from
9e4c20b to
cc6f4f0
Compare
joker234
requested changes
Jul 5, 2021
...l/oshpbf-parser/src/main/java/org/heigit/bigspatialdata/oshpbf/parser/rx/RxOshPbfReader.java
Outdated
Show resolved
Hide resolved
...l/oshpbf-parser/src/main/java/org/heigit/bigspatialdata/oshpbf/parser/rx/RxOshPbfReader.java
Outdated
Show resolved
Hide resolved
…ta/oshpbf/parser/rx/RxOshPbfReader.java Co-authored-by: Johannes Visintini <[email protected]>
…ta/oshpbf/parser/rx/RxOshPbfReader.java Co-authored-by: Johannes Visintini <[email protected]>
joker234
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes Issue #286.
Description
Revert some code refactoring, 5e8ba71 which leads to eagerly closed streams!
Corresponding issue
Closes #286