Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes being added to layer even if route cannot be not generated #294

Open
rabidllama opened this issue Jan 31, 2025 · 1 comment
Open
Labels

Comments

@rabidllama
Copy link

When you perform a "Directions From 2 Point-Layers", if a route cannot be generated (start/end points cannot be found on the network), the route information is filled in with the information from the last succesful route generation.

For example, I use two files, each with 100 points. I set the start and end id fields to be a numerical id of the point in each file. When I run the process, only two of the routes can be generated, those with point ID 11 and ID 56 (due to other points being too far from the network). The resultant layer contains 89 routes, starting with a route from the points with ID 11, and then there are 45 identical routes to that one, before the one for ID 56 gets a different route, and then there are 33 identical routes to that one.

It should be the case that when a route cannot be generated, no feature is added to the layer.

@rabidllama rabidllama added the bug label Jan 31, 2025
@rabidllama
Copy link
Author

rabidllama commented Jan 31, 2025

Seems to only happen when I am calling to a local instance of ors, when calling the public API I get the correct results with only the findable routes being present in the layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant