Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing Algorithm tests only test existence of output, not correctness #283

Open
koebi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #284
Open

Processing Algorithm tests only test existence of output, not correctness #283

koebi opened this issue Oct 18, 2024 · 0 comments · May be fixed by #284

Comments

@koebi
Copy link
Collaborator

koebi commented Oct 18, 2024

We only test if an output layer exists, not if it contains something.
Given that we are testing against a live API with regularly changing data, results are bound to change but some assumptions can be made:

  • Directions:

    • resulting PolyLine has length > 0
  • Isochrones:

    • resulting Polygons have area > 0
    • "outer" Polygon has bigger area than "inner" polygon
  • Matrix:

    • distances/durations are > 0
  • Export:

    • resulting PolyLine-Layer has Lines
    • resulting Point Layer has Points
@merydian merydian linked a pull request Oct 24, 2024 that will close this issue
@merydian merydian linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant