Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Virtus' with 'dry-types' for Coercion #37

Open
ChristianClassen opened this issue May 3, 2017 · 5 comments
Open

Replace 'Virtus' with 'dry-types' for Coercion #37

ChristianClassen opened this issue May 3, 2017 · 5 comments

Comments

@ChristianClassen
Copy link

Hey,

first of all, thanks for writing this great gem!
Are there any plans to replace the 'Virtus' dependency with the much better maintained dry-types coercion engine? (Same creator)
It's even the default coercion backend for the Trailblazer architecture.

Btw, the creator of Virtus explains why he started developing the dry-types gem: Virtus to be abandoned by its creator?

Would love to hear your thoughts about it.

@ramontayag
Copy link
Contributor

Hello @b2e9f523 - glad you find it useful!

I'm familiar with the Dry gems and use them for other projects. I considered moving but dry-types is not 1.x yet. I'm concerned with breaking changes.

I don't see any reason other than that. It seems the feature set storext needs can be found in dry-types. Perhaps we can keep this open until dry-rb reaches 1.x?

@ChristianClassen
Copy link
Author

Yes, better wait until dry-types is mature enough to rely on without facing breaking changes.

@flvrone
Copy link

flvrone commented May 13, 2019

The time has come 🎉
https://dry-rb.org/news/2019/04/23/dry-types-and-dry-struct-1-0-0-released/

Also, they will release dry-validation and dry-schema 1.0.0 soon, if those might be needed here as well.

@ramontayag
Copy link
Contributor

That's great!

If anyone wants to take a look at upgrading, please do - I won't be able to do so for a while. All the conversion happens through a proxy object that is created per class that uses Storext.

@swrobel
Copy link

swrobel commented Jun 7, 2021

FYI, virtus 2.0 was just released. It seems that this gem's dependency on it is unbounded, so compatibility could possibly be broken by this major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants