Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use proper module versioning tag #85

Open
syntaqx opened this issue Jul 9, 2024 · 1 comment
Open

Please use proper module versioning tag #85

syntaqx opened this issue Jul 9, 2024 · 1 comment
Labels

Comments

@syntaqx
Copy link

syntaqx commented Jul 9, 2024

Currently, if you go get this package, the value returned is:

go get github.com/FusionAuth/go-client/pkg/fusionauth@latest
go: downloading github.com/FusionAuth/go-client v0.0.0-20240703195400-20df799688c3

Which matches the latest sha in main 20df799, following pseudo-versions in go modules.

https://pkg.go.dev/github.com/FusionAuth/go-client/pkg/fusionauth?tab=versions
image

This would normally not be a huge deal, except that the latest version is returning this error for my application:

# github.com/FusionAuth/go-client/pkg/fusionauth
../../../go/pkg/mod/github.com/!fusion!auth/[email protected]/pkg/fusionauth/Domain.go:4010:2: undefined: LinkedHashMap

Which we can still:

go get github.com/FusionAuth/go-client/pkg/[email protected]
go: downloading github.com/FusionAuth/go-client v0.0.0-20191211173910-6751b41cf288

However, that still pins releases as a pseudo version.

The side effect of this, is it's hard to know from what's currently a work-in-progress on the main branch vs a stable release, and even harder to pin it correctly in a go.mod

To correctly use module versions, tags should be released in the format of v1.12.1, instead of the format being used 1.12.1 (missing the v prefix).

Can you please release the latest stable as a properly named tag?

https://go.dev/ref/mod

@mooreds
Copy link
Contributor

mooreds commented Jul 9, 2024

Thanks for the suggestion. I'm going to leave this issue open so we can address it.

But your root issue of undefined: LinkedHashMap should be resolved by the commit in this PR, I believe: #82

@linear linear bot added DX Go labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants