Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts and other cURL errors are not handled #28

Open
glen-84 opened this issue Oct 5, 2022 · 1 comment
Open

Timeouts and other cURL errors are not handled #28

glen-84 opened this issue Oct 5, 2022 · 1 comment

Comments

@glen-84
Copy link

glen-84 commented Oct 5, 2022

When there's a read timeout, the response looks something like this:

FusionAuth\ClientResponse::__set_state(array(
   'errorResponse' => NULL,
   'exception' => NULL,
   'method' => 'PATCH',
   'request' => 
  array (
    'user' => 
    array (
        /* ... */
    ),
  ),
   'successResponse' => NULL,
   'status' => 0,
))

i.e. The errorResponse, exception, and successResponse are all NULL.

I think the code needs to use curl_errno to check for errors.

@mooreds
Copy link
Contributor

mooreds commented Oct 11, 2022

Thanks for filing this @glen-84 . We're looking at overhauling our client libraries and will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants