Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Align combo number offsets #2848

Open
Hundrec opened this issue Jun 18, 2024 · 2 comments · May be fixed by FunkinCrew/funkin.assets#70
Open

Enhancement: Align combo number offsets #2848

Hundrec opened this issue Jun 18, 2024 · 2 comments · May be fixed by FunkinCrew/funkin.assets#70
Labels
status: pending triage The bug or PR has not been reviewed yet.

Comments

@Hundrec
Copy link
Contributor

Hundrec commented Jun 18, 2024 •
edited
Loading

What is your suggestion, and why should it be implemented?

Currently, the combo numbers are cropped inconsistently. This leads to variation in the placement of the numbers on the combo display.

I've cropped and aligned all of the numbers to be 120x120 so that combos display consistently.

If the varying offsets are intentional, I totally get it! I honestly think the current offsets have a sort of charm when they move around.

I've started a PR here: FunkinCrew/funkin.assets#70

Original Behavior

combo.offsets.before.mp4

Aligned Offsets

combo.offsets.aligned.mp4
@Hundrec Hundrec mentioned this issue Jun 18, 2024
Closed
@CrusherNotDrip
Copy link

This is completely unrelated to this issue but you are so goated at this game omg

@Hundrec
Copy link
Contributor Author

Hundrec commented Jun 18, 2024

Bahaha I'm just using a build with modified botplay 😄

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jun 25, 2024
@Hundrec Hundrec linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize and align combo popup numbers Hundrec/funkin.assets
3 participants
@EliteMasterEric @CrusherNotDrip @Hundrec