Bug Report: Note trails position are not updated when moving a note in editor

[amyspark-ng]

Issue Checklist

• I have read the pinned Issues Guide
• I have checked the Issues/Discussions pages to see if my issue has already been reported
• I have properly named my issue

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

When you move notes in the editor the trail that follows them won't move with them

2025-02-08_13-13-27.mp4

Steps to Reproduce

1. Open chart editor
2. Select long notes
3. Move them

[Lasercar]

dangit, I close one issue, and 2 more pop up!

Seriously though, I'll investigate this. Maybe it's a simple fix? I don't think it's an easy fix, as regular notes seem to be used for all the stuff and the hold notes are created afterwards at the points of the regular notes.

@amyspark-ng It's been fixed! Though not by me.

[amyspark-ng]

it do be like that

do update me how you fix it! i was looking through the code but couldn't find how to fix it, chart editor code is still an enigma for me

[amyspark-ng]

https://github.com/FunkinCrew/Funkin/blob/develop/source%2Ffunkin%2Fui%2Fdebug%2Fcharting%2FChartEditorState.hx#L3763 This line seems to be the one that changes the position but being honest i don't really understand how to fix it

[NotHyper-474]

https://github.com/FunkinCrew/Funkin/blob/develop/source%2Ffunkin%2Fui%2Fdebug%2Fcharting%2FChartEditorState.hx#L3763 This line seems to be the one that changes the position but being honest i don't really understand how to fix it

Our goat Kolo already made a PR addressing the issue :) #4127

[Lasercar]

This issue now has a pending PR.

That's all the PRs here now checked for issues they link fixing/closing, I'll check the assets submodule tomorrow, hopefully I'll find a few more.

We went from 48 issues with pending PRs, to 69. Nice (though there's still a few that haven't gotten the label yet, rip). It'll be very satisfying once all the PRs get merged! An issue number below 400!