Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Missing part or all of a hold note prevents health gain for (double) the duration missed #4086

Open
3 tasks done
Lasercar opened this issue Feb 3, 2025 · 3 comments
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Comments

@Lasercar
Copy link
Contributor

Lasercar commented Feb 3, 2025

Issue Checklist

  • I have read the pinned Issues Guide
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
  • I have properly named my enhancement

What is your suggestion, and why should it be implemented?

Title. Missing part or all of a hold note prevents health gain for (double) the duration missed (because if it was just the same duration as the hold note it would have zero effect, because that part is the dropped hold note).

I just came up with this today, and I thought it was so good of an idea that I actually kinda spaced out a bit while I was thinking about it.

The point is, missing a hold note at the moment has too few consequences, but of course going back to was it was like before isn't an option so how about this sort of middle ground option?

@Lasercar Lasercar added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Feb 3, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 3, 2025

I think missing the hold note's health bonus is a fair consequence. Disabling health gain for other notes would be too punishing, especially considering how easy it is to drop a hold note right before it's completed.

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 3, 2025

Well, it could be balanced a bit by making the prevented health gain only apply to regular notes, so you could make up for your "lost" health by hitting the next hold note fully.

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 3, 2025

Regular notes give a lot of health compared to hold notes, so nullifying them after a hold note would be too punishing. I don't think this should be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

2 participants