Enhancement: Add results screen to chart editor when you finish the song

[amyspark-ng]

Issue Checklist

• I have read the pinned Issues Guide
• I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
• I have properly named my enhancement

What is your suggestion, and why should it be implemented?

I think if you have played for a decent amount of time (more than half of the length of the song) and you're playtesting a chart, it should send you to the results screen when you finish, just to see your score, and if you press enter/exit the results, it sends you back to the chart editor

[Lasercar]

Hmm, well the results screen is it's own state, should this should be possible.

That's not to say that I'd be able to do it though.

I managed to do it. But mousing over the chart afterwards causes it to crash through a null reference?

Hmm, seems like as long as you give it some time to do it thing, it doesn't crash.

[Lasercar]

You can checkout my garbage code here: https://github.com/Lasercar/Funkin/tree/chart-editor-playtest-results-screen-hack

I don't think I'll even be making a draft PR for this one while it still can crash through a null reference as I mentioned above.

If someone else can figure out how to fix it, then I could start a PR draft.

[amyspark-ng]

you should check what the playstate does when you press the debug chart menu, copy the code and that's it

[Lasercar]

Holy crap! All I needed to do was clear all the timers before closing the result screen:

2025-02-03.20-12-34.1.mp4

I can see why you'd want to clear all the timers before moving to a different state. If only we could target which timers to actually clear though, then my screenshot buffer saving could be buffered out properly.

Also, I noticed a bug where the chart editor doesn't properly load a song through the button press - you can see in the video how it thinks it's pico's mix when it's not. When it loads erect songs it says that it loaded it properly but it actually just loaded the normal song. Is there an issue for this already? I fixed this myself.

And yes, I renamed the branch as it's no longer a buggy hack.

[Lasercar]

old issue with my PR that's been fixed

Also, I encountered this weird issue while before I realised all I had to do was clear the timers:

No idea if it's a bug with the code I added or how to replicate it though.

[EliteMasterEric]

I approve of this suggestion, so long as the results screen is a toggle in the Playtest Properties panel so you can turn it off when not needed.

[Lasercar]

I approve of this suggestion, so long as the results screen is a toggle in the Playtest Properties panel so you can turn it off when not needed.

Yeah, I've made it a toggle now.