Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Tabs support for preference items #4043

Open
2 tasks done
AbnormalPoof opened this issue Jan 26, 2025 · 0 comments
Open
2 tasks done

Enhancement: Tabs support for preference items #4043

AbnormalPoof opened this issue Jan 26, 2025 · 0 comments
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.

Comments

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Jan 26, 2025

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

Currently, all preference items created by mods are grouped together with base game's options. This can make the menu look really cluttered when you have a lot of mods with a lot of modded preferences.

Image

You can add a sort of "separator" of some kind like this:

Image

event.targetState.pages.get("preferences").add(prefs.items.createItem(120, 120 * prefs.items.length + 30, "-- FUNKER SELECTOR --", "bold", () -> {})).fireInstantly = true;

However, this is very janky (and doesn't even work in the develop branch).
Alternatively, could also make an Options page of your own; but that's ALSO extremely janky since you have to effectively clone PreferencesMenu, remove everything in it, and THEN add your own preferences.

My suggestion is to add tabs to the preference menu, which can be navigated through using Q or E (similar to how Freeplay handles sorting).
This would make everything less cluttered visually since mods could have their own custom preferences in a different tab, without being grouped in with base game's options.

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 26, 2025
@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. topic: mods Related to the creation or use of mods. and removed status: pending triage Awaiting review. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

1 participant