Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Still run tests in CI even if yarn compile has an error #320

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 21, 2022 · 0 comments
Open
3 tasks done
Labels
area: tooling Builds, infrastructure, packages, and other repository management good first issue Good for newcomers - welcome aboard! status: accepting prs Go ahead and send a pull request to resolve this issue!

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

If there's an error in yarn compile, test.yml won't run yarn test. That's annoying because tests can still run even if there's a type error -- and sometimes type errors are just mismatches in the type system, not runtime issues.

Let's have test.yml ignore the exit code from yarn compile.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Go ahead and send a pull request to resolve this issue! area: tooling Builds, infrastructure, packages, and other repository management good first issue Good for newcomers - welcome aboard! labels Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Builds, infrastructure, packages, and other repository management good first issue Good for newcomers - welcome aboard! status: accepting prs Go ahead and send a pull request to resolve this issue!
Projects
None yet
Development

No branches or pull requests

1 participant