chore: Address constructor now accepts a range of inputs.
#3600
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petertonysmith94
changed the title
Address constructor now accepts a range of inputs.
|
Opened this PR early (need to update documentation, etc), just to ensure this is the direction we wish to pursue. Does anyone have any issues with this approach? cc @FuelLabs/sdk-ts @LuizAsFight |
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate and
nedsalk
as code owners
| @@ -240,8 +221,7 @@ export class Address { | |||
| ); | |||
| } | |||
|
|
|||
| const paddedAddress = padFirst12BytesOfEvmAddress(evmAddress); | |||
| return new Address(paddedAddress); | |||
| return new Address(evmAddress); | |||
There was a problem hiding this comment.
I don't understand why we'd want to have the Address class represent anything but a fuel-compatible address. It seems more appropriate to me that we differentiate between an Address and an EvmAddress, the same way Sway does it.
@LuizAsFight @luizstacio What are your thoughts here?
There was a problem hiding this comment.
@nedsalk I believe this is done for simplicity since on Fuel an EVM address is represented the same way as Fuel addresses, using 32 bytes. The difference is that an EVM address is padded with zeros to make it 32 bytes.
| * | ||
| * @param publicKey - A wallets public key | ||
| * @returns A new `Address` instance | ||
| * | ||
| * @deprecated Use `new Address` instead | ||
| */ | ||
| static fromPublicKey(publicKey: string): Address { | ||
| if (!isPublicKey(publicKey)) { | ||
| throw new FuelError(FuelError.CODES.INVALID_PUBLIC_KEY, `Invalid Public Key: ${publicKey}.`); | ||
| } | ||
|
|
||
| const b256Address = hexlify(sha256(arrayify(publicKey))); | ||
| const b256Address = fromPublicKeyToB256(publicKey); |
There was a problem hiding this comment.
@petertonysmith94 Should we update the docs to conform with these new guidelines?
There was a problem hiding this comment.
@Torres-ssf as stated in the comment, opened this early to get feedback/confirmation to proceed.
If we're happy with the approach, I will finalise the documentation + update references :)
|
Coverage Report:
Changed Files:
|
petertonysmith94
dismissed
Torres-ssf’s stale review
Addressed documentation.
AddressDX #3598Release notes
In this release, we:
Addressconstructor now accepts a range of different inputsSummary
Addressconstructor now accepts a range of inputs:AddressinstanceB256stringEVMaddress stringChecklist