You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the FuelsEventListener type returns void. We should update the return type to Promise<void> | void because being able to pass in async callbacks comes in quite handy sometimes. Besides this type, we should update the onFailure listener as well.
This would entail always awaiting the listener callbacks. As of now, sometimes we do it, sometimes we don't.
The text was updated successfully, but these errors were encountered:
@arboleya I don't know if I understood you correctly in #3504 (comment), so I'll just assume that you meant making it always async so that the return type is Promise<void> only. This would be a breaking change - people's compilations/linters would fail because their synchronous callbacks returning void can't be assigned to the new type returning Promise<void>, hence why I described the return type to be Promise<void> | void in the issue.
Currently, the
FuelsEventListener
type returnsvoid
. We should update the return type toPromise<void> | void
because being able to pass in async callbacks comes in quite handy sometimes. Besides this type, we should update theonFailure
listener as well.This would entail always
await
ing the listener callbacks. As of now, sometimes we do it, sometimes we don't.The text was updated successfully, but these errors were encountered: