Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate API docs url/deployment #3572

Open
arboleya opened this issue Jan 10, 2025 · 1 comment · May be fixed by #3602
Open

Segregate API docs url/deployment #3572

arboleya opened this issue Jan 10, 2025 · 1 comment · May be fixed by #3602
Assignees
Labels
docs Requests pertinent to documentation

Comments

@arboleya
Copy link
Member

arboleya commented Jan 10, 2025

Our docs appear on docs-hub in two versions: stable and nightly.

We need to find a way to align that with our API-docs so that merging related PRs to master (and thus re-deploying the app) doesn't risk breaking the links in the stable version of the docs-hub.

We'll go from this:

Docs API-docs
nightly merged merged
stable released merged (1)

To this:

Docs API-docs
nightly merged merged
stable released released (2)

Note

1 = wrong
2 = correct

@arboleya arboleya added the docs Requests pertinent to documentation label Jan 10, 2025
@nedsalk nedsalk self-assigned this Jan 10, 2025
@nedsalk
Copy link
Contributor

nedsalk commented Jan 14, 2025

Had a chat with @petertonysmith94 and this is what we came up with:

  1. Create two environments on vercel:
  2. Replace all links in our docs with a magic string (e.g. DOCS_API_URL) which must be replaced in all apps consuming the docs:
    • In our vitepress docs:
      • a localhost version of the docs-api when running dev.
      • with an /api endpoint when deploying PR docs. This requires adding the docs-api outputs to docs/dist/api and vite would then be serving them alongside our docs for every PR.
    • In the official docs with the stable link for the stable docs and the nightly link for the nightly docs. This will require work on the docs-hub repo.
    • In our markdown link checker workflow with a localhost url on which we'll serve the docs just for the link checker to pass. This also solves the issue of new links on the api docs failing this workflow because they're not on nightly yet, as now the served localhost docs would be based on the PR and not on master.

@nedsalk nedsalk linked a pull request Jan 21, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants