Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: redistributed the @fuel-ts/interfaces package #3492

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

chore!: redistributed the @fuel-ts/interfaces package #3492

wants to merge 6 commits into from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 20, 2024 •
edited
Loading

Release notes

In this release, we:

  • Removed the AbstractAddress in favour of the Address class.

Summary

  • Redistributed the @fuel-ts/interfaces to their associated packages.
  • Removed the AbstractAddress in favour of the Address class to ensure synced functionality.

Breaking Changes

  • Removed the AbstractAddress class; use the Address class instead.
// Before
import { AbstractAddress } from 'fuels';

// After
import { Address } from 'fuels';
  • Removed the @fuel-ts/interfaces package; use the fuels package instead.
// Before
import { BytesLike } from '@fuel-ts/interfaces'

// After
import { BytesLike } from 'fuels'

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Dec 20, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 20, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:42pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:42pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:42pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3492 will degrade performances by 20.19%

Comparing ps/chore/removed-interfaces-package (0be07ee) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/chore/removed-interfaces-package Change
❌ should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 63 ms -20.19%

@petertonysmith94 petertonysmith94 changed the title !chore: redistributed the @fuel-ts/interfaces package chore!: redistributed the @fuel-ts/interfaces package Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.3%(-0.03%) 69.69%(-0.15%) 74.16%(-0.04%) 76.31%(-0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/address/src/address.ts 90%
(-0.16%)		 80.55%
(+0%)		 85.71%
(+0%)		 90.16%
(-0.16%)
🔴 packages/address/src/utils.ts 77.14%
(-7.23%)		 60%
(-18.94%)		 85.71%
(-6.59%)		 77.77%
(-7.07%)
🔴 packages/logger/src/index.ts 83.33%
(-0.45%)		 80%
(+0%)		 52.38%
(+0%)		 78.57%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm will be requested when the pull request is marked ready for review digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya will be requested when the pull request is marked ready for review arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf will be requested when the pull request is marked ready for review Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 will be requested when the pull request is marked ready for review Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate will be requested when the pull request is marked ready for review danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk will be requested when the pull request is marked ready for review nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad will be requested when the pull request is marked ready for review maschad is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toEvmAddress function is missing in AbstractAddress type, causing TypeScript error on import
1 participant
@petertonysmith94