Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test ui script in package's json #3486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: test ui script in package's json #3486

wants to merge 2 commits into from
+8 −3

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Dec 16, 2024 •
edited
Loading

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya added the bug Issue is a bug label Dec 16, 2024
@arboleya arboleya self-assigned this Dec 16, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 9:14pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 9:14pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 9:14pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #3486 will degrade performances by 20.44%

Comparing aa/fix/ui-script-call (6793369) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master aa/fix/ui-script-call Change
❌ should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 63.2 ms -20.44%

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.84%(+0%) 74.2%(+0%) 76.34%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94
Copy link
Contributor

Are these tests being run in the CI?

@arboleya
Copy link
Member Author

Are these tests being run in the CI?

I don't think so, but will defer to @Dhaiwat10 @danielbate.

@petertonysmith94 What is your concern?

@petertonysmith94
Copy link
Contributor

I don't think so, but will defer to @Dhaiwat10 @danielbate.

@petertonysmith94 What is your concern?

The main concern would be shipping broken tests with the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@arboleya arboleya

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run test:ui inside new create fuels app
6 participants
@arboleya @petertonysmith94 @danielbate @nedsalk @Torres-ssf @Dhaiwat10