Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run test:ui inside new create fuels app #3480

Open
arboleya opened this issue Dec 13, 2024 · 2 comments · May be fixed by #3486
Open

Can't run test:ui inside new create fuels app #3480

arboleya opened this issue Dec 13, 2024 · 2 comments · May be fixed by #3486
Assignees
Labels
bug Issue is a bug

Comments

@arboleya
Copy link
Member

After creating a new app with:

pnpm create fuels

One can't run the UI tests via:

pnpm test:ui

The same happens for bun and npm as well.

Prepending sh to the script seems to fix the issue.

"test:ui": "sh ./test/ui/test-ui.sh"
@arboleya arboleya added the bug Issue is a bug label Dec 13, 2024
@arboleya arboleya changed the title Can't run test:ui inside for newly generated create fuels app Can't run test:ui inside new create fuels app Dec 13, 2024
@maschad
Copy link
Member

maschad commented Dec 13, 2024

Given a user may not have run the build command before on a freshly generated create-fuels project, perhaps this command should also include npm run build to ensure they don't run into any errors when running the ui tests.

"test:ui": "npm run build && sh ./test/ui/test-ui.sh"

@arboleya
Copy link
Member Author

I'm not sure I'd do that, as that would build the app every time.

Users can do that if they want to, but overall, I think is common sense to build first test later.

@arboleya arboleya self-assigned this Dec 16, 2024
@arboleya arboleya linked a pull request Dec 16, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants